Exception handling with ServiceResult.ExceptionList

I am executing the processors with AbortOnFailure = true, and I want to rethrow the exception(s) that has been caught in the ServiceBaseCore Process() method. There will only be one error in the ExceptionList. However, when I rethrow the exception stored in the ExceptionsList, .NET picks it up as a new error and I lose the stack trace, source and targetid of the original exception.  InnerException and GetBaseException()  do not apply here, because the exception chain has been interrupted when the ServiceBaseCore.Process() catches any exceptions.  Does anyone have any suggestions for bubbling up the original exception?  My code looks like this:

ServiceResult result = Execute (true);

if ( result.ExceptionList.Count > 0 )

foreach ( Exception exc in result.ExceptionList.Values )

string message = string.Format ( "Message: {0} \r\nSource: {1} \r\nStackTrace: {2}\r\nTargetSite: ", exc.Message, exc.Source, exc.StackTrace, exc.TargetSite );

throw new Exception ( message );

If you have abortOnFailure set to true, there will always be at most only 1 exception there.

so just try to rethrow the same exception.

if (result.ExceptionList.Count > 0)
    throw result.ExceptionList.Values[0] as Exception;

 Robert,

 That code results in the following error:

Error    2    Cannot apply indexing with [] to an expression of type 'System.Collections.Generic.Dictionary<TransitApp.Services.ProcessorBase,System.Exception>.ValueCollection'

I'm not using the nightly builds and this is the version from back in January, so maybe yours works?

Thanks.

 

skbach, I am using 2.0.1 version of framework and get same error when doing what swin suggests (but it might work in later versions). Have you tried the following?

ServiceResult result = Execute (true);

if ( result.ExceptionList.Count > 0 )

{

foreach ( Exception exc in result.ExceptionList.Values )

{

throw exc;

}

}

This should just re throw the first exception, and as swin says the only exception in list because you are aborting on failure, in the list.

I have just applied this approach in some code I am working on and it does indeed rethrow the error. 

 Awesome SBB...I'll give that a try...

 sk
 

As far as I know, the only way to preserve the original stack information is to use the 'throw' statement by itself in a catch block, any other use of the throw statement, i.e. throw new XXXException() will figure as though the exception occurred at the location of the throw statement in code.

However, i think you can achieve what you need, because you do have the original exception in the ExceptionList.

Try something like this:

foreach ( Exception exc in result.ExceptionList.Values )

{

string message = string.Format ( "Exception rethrown {0}.", exc.ToString() );

throw new Exception ( message, exc );

}

This should preserve the original Exception, with all its info.