CodeSmith Community

Hi,

I was looking at the generated code and saw a lot of these kind of coding constructions in this case the weblibrary/data/ProviderDataSource.cst:

public ProviderDataSourceInsertMethod InsertMethod
  {
   get
   {
    ProviderDataSourceInsertMethod insertMethod = ProviderDataSourceInsertMethod.<%= insertMethods[0] %>;
    Object method = ViewState["InsertMethod"];
    if ( method != null )
    {
     insertMethod = (ProviderDataSourceInsertMethod) method;
    }
    return insertMethod;
   }

wouldn't the following code be better?

public ProviderDataSourceInsertMethod InsertMethod
  {
   get
   {
    ProviderDataSourceInsertMethod insertMethod = null;
    Object method = ViewState["InsertMethod"];
    if ( method != null )
    {
     insertMethod = (ProviderDataSourceInsertMethod) method;
    }
    else
    {
     insertMethod = ProviderDataSourceInsertMethod.<%= insertMethods[0] %>
    }
    return insertMethod;
   }

Because now it doesn't have to execute unnessesary code

Just my 2 cents

Avoiding use of the null keyword, actually improves the stability of the code (reducing number of NullReferenceExceptions to deal with)

        public ProviderDataSourceInsertMethod InsertMethod
        {
            get
            {
                // -- i wouldn't say the line bellow executes the unnessesary code, but rather
                // -- initializes a local variable to an enum value - named constant so to speak
                ProviderDataSourceInsertMethod insertMethod = ProviderDataSourceInsertMethod.Insert;
                Object method = ViewState["InsertMethod"];
                if ( method != null )
                {
                    insertMethod = (ProviderDataSourceInsertMethod) method;
                }
                return insertMethod;
            }
            set { ViewState["InsertMethod"] = value; }
        }

    /// <summary>
    /// Enumeration of method names available for the ProviderDataSource.InsertMethod property.
    /// </summary>
    public enum ProviderDataSourceInsertMethod
    {
        /// <summary>
        /// Represents the Insert method.
        /// </summary>
        Insert,
        /// <summary>
        /// Represents the Save method.
        /// </summary>
        Save,
        /// <summary>
        /// Represents the DeepSave method.
        /// </summary>
        DeepSave
    }