CodeSmith Community

There seems to be a an issue with the strongly typed filters.

When doing a "Contains" search with more than one value i.e. "for the" the SQL command  gets a WHERE clause like the following:

"where  (CompanyName LIKE @Param0 AND CompanyName LIKE @Param1) "  - this is ok, but @Param0 contains "%for" and @Param1 contains "the%" - which means no rows are matched.  Both the params need to be wrapped in "%" i.e "%for%" and "%the%" for it to work as expected.

swin 

Hi Ben,

My current search requirements were fairly straightforward and your changes work fine for me, so thanks for that.

However, you could argue that the search should work like the main search engines i.e Google, Windows Live, which do a word search by default and if you want an exact phrase you have to include the quotes (see http://www.google.co.uk/help/basics.html).  Although I imagine creating similar features to Google may well be out of scope of this class!

So I'm happy with what you've done, but maybe a future enhancement would be to allow you to specify which kind of filter to use i.e. phrase (default) or word?

Thanks again

swin 

BigJ:

I love the idea, and I'd like to implement it.  However, I'd also love the option to exclude the quotes, if necessary.  Or, heck, add another option to include BOTH types of searches.  Search by combining the words and separating them as well.

Also, I'm noticing that the contains parameters in the WHERE clause are filtered with AND.  How about an option to do with OR and AND/OR?

... just throwing some ideas out...

Here's a sample of the new SqlFilterType Enum (if the name is appropriate...)

/// <summary>
/// Enumeration of SQL Filter Types.
/// </summary>
public enum SqlFilterType
{
    /// <summary>
    /// Represents an Individual Word filter
    /// </summary>
    /// <example>(if using SqlComparisonType.Contains) CompanyName LIKE "%Acme" AND CompanyName LIKE "Company%"</example>
    Word,
    /// <summary>
    /// Represents a Phrase filter
    /// </summary>
    /// <example>(if using SqlComparisonType.Contains) CompanyName LIKE "%Acme Company%"</example>
    Phrase
}

I've submitted a patch for this here:

http://community.codesmithtools.com/forums/p/8376/30771.aspx#30771

By default, the filter will use an SqlFilterType of Word, as it did before the change.